Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending the syntax of GRIN: HPT #42

Merged
merged 14 commits into from
Oct 18, 2019
Merged

Extending the syntax of GRIN: HPT #42

merged 14 commits into from
Oct 18, 2019

Conversation

Anabra
Copy link
Member

@Anabra Anabra commented Oct 7, 2019 •
edited
Loading

Modified HPT and the linter such that they correctly handle the new syntax.

  • type checker
  • linter
  • HPT
  • linter tests
  • HPT tests
  • Add more tests to HPT (for new syntax)
  • Possibly add tests for type checker (?)

For more details see #32.

@Anabra Anabra added wip Work in progress review Ready for review labels Oct 7, 2019
@Anabra Anabra self-assigned this Oct 7, 2019
andorp
andorp approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@andorp andorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are seemed OK. In the short term we will migrate to the datalog engine.

csabahruska
csabahruska approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@csabahruska csabahruska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Looks it does the necessary cloning.
Looks good to me.

@Anabra Anabra merged commit 2a7f554 into 32-extended-syntax Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andorp andorp andorp approved these changes

@csabahruska csabahruska csabahruska approved these changes

Assignees

@Anabra Anabra

Labels
review Ready for review wip Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anabra @csabahruska @andorp