Lint: Node pattern match uses sub-type instead of type equality. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anabra
requested changes
Mar 3, 2020
Comment on lines
+227
to
237
| it "doesn't alert over-approximated binds" $ do | ||
| let program = [prog| | ||
| main = | ||
| n0 <- pure (CInt 0) | ||
| n1 <- case n0 of | ||
| (CInt c0) -> pure n0 | ||
| (CFloat c1) -> | ||
| a0 <- pure (CFloat 2.0) | ||
| pure a0 | ||
| i <- pure (CInt 1) | ||
| f <- pure (CFloat 1.0) | ||
| l <- store i | ||
| update l f | ||
| v <- fetch l | ||
| (CFloat f2) <- pure v | ||
| pure () | ||
| |] |
There was a problem hiding this comment.
Isn't this semantically invalid GRIN code? As in store, fetch and update must always come in this order for a given location.
There was a problem hiding this comment.
I am not sure. We could simply insert a fetch operation before the update, and that wouldn't change the result of the HPT.
@csabahruska What do you think?
There was a problem hiding this comment.
IMO it is not the point of this specific test so it is acceptable here.
grin/test/LintSpec.hs
Outdated
Comment on lines
242
to
252
| it "disregards variable patterns" $ do | ||
| let program = [prog| | ||
| main = | ||
| n0 <- case 0 of | ||
| 0 -> | ||
| n1 <- pure (CInt 0) | ||
| pure n1 | ||
| 1 -> | ||
| n2 <- pure (CFloat 0.0) | ||
| pure n2 | ||
| (CInt x) <- case n0 of | ||
| n0 <- pure (CInt 0) | ||
| n1 <- case n0 of | ||
| (CInt c0) -> pure n0 | ||
| (CFloat c1) -> | ||
| a0 <- pure (CInt 0) | ||
| a0 <- pure (CFloat 2.0) | ||
| pure a0 | ||
| pure () | ||
| |] |
There was a problem hiding this comment.
Could you please name all subexpressions, so that adopting these tests to the new syntax will be easier?
Anabra
reviewed
Mar 3, 2020
Co-Authored-By: Peter Podlovics <peter.d.podlovics@gmail.com>
Co-Authored-By: Peter Podlovics <peter.d.podlovics@gmail.com>
Co-Authored-By: Peter Podlovics <peter.d.podlovics@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.