Add default tool memory embedding driver, cleanup vector store, query engine, and tool memory defaults #231
Conversation
There was a problem hiding this comment.
This only works if the prompt driver is OpenAI. Otherwise, this breaks. Let's not make this change but instead document embedding driver API keys better.
Or add a default embedding driver to structure, so it propagates to the underlying components like memory?
collindutter
changed the title
collindutter
force-pushed
the
embedding-api-key
branch
from
54f24d3
to
2b44474
Compare
- Remove VectorQueryEngine.vector_store_driver default - Remove TextToolMemory.query_engine default - Remove TextToolMemory.summary_engine default - Rename Structure.default_tool_memory_embedding_driver to Structure.embedding_driver - Remove TextQueryTask.query_engine default - Update tests
There was a problem hiding this comment.
In addition to your changes, I cleaned up a bunch of defaults that shouldn't exist anymore. We want to control one happy path at the structure level to avoid dependency injection complexity. If the user wants to something more advanced, they should be able to set underlying dependencies depending on their needs.
We should document this better.
vasinov
changed the title
|
@vasinov what about Should we set a happy path in |
https://github.com/orgs/griptape-ai/discussions/230