Fixes for newer astroid versions #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dsagal
reviewed
Nov 22, 2022
| @@ -88,6 +83,9 @@ def _visit_after_children(self, node, parent_token, token): | |||
| first = token | |||
| last = None | |||
| for child in cast(Callable, self._iter_children)(node): | |||
| # astroid slices have especially wrong positions, we don't want them to corrupt their parents. | |||
| if util.is_empty_astroid_slice(child): | |||
There was a problem hiding this comment.
Might it be a better alternative to filter out empty slices in iter_children_astroid in util.py? (Perhaps that would be wrong, but seems this is done for some nodes already.)
There was a problem hiding this comment.
Just tried that, it didn't work. Other places need those child nodes to be included.
| @@ -814,6 +819,10 @@ def assert_nodes_equal(self, t1, t2): | |||
| else: | |||
| self.assertEqual(type(t1), type(t2)) | |||
|
|
|||
| if isinstance(t1, AstroidPosition): | |||
There was a problem hiding this comment.
Just checking that this is a separate kind of node and not a base class for everything in new astroid :)
There was a problem hiding this comment.
It's not a node, it's this:
class Position(NamedTuple):
"""Position with line and column information."""
lineno: int
col_offset: int
end_lineno: int
end_col_offset: int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70 and #79
astroid.node_classestoastroid.nodes.test_slices.Positionwhen asserting equal astroid nodes.