feat: forms inhibited when summary selected and vice versa #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflorent
suggested changes
Jun 26, 2024
fflorent
approved these changes
Jul 3, 2024
fflorent
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Thanks @hexaltation!
Only have a few small comments and suggestions.
test/nbrowser/saveViewSection.ts
Outdated
| await gu.checkForErrors(); | ||
| }); | ||
|
|
||
| it("Should disable form when summary is selected", async () => { |
There was a problem hiding this comment.
Suggested change
| it("Should disable form when summary is selected", async () => { | |
| it("should disable form when summary is selected", async () => { |
test/nbrowser/saveViewSection.ts
Outdated
|
|
||
| // close page widget picker | ||
| await driver.sendKeys(Key.ESCAPE); | ||
| await gu.checkForErrors(); |
There was a problem hiding this comment.
Suggested change
| await gu.checkForErrors(); |
hexaltation
force-pushed
the
967-forms-summary
branch
from
7cfca06
to
66c07b6
Compare
georgegevoian
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #967
Following behaviour proposed by @dsagal in the issue