#1042 improve switch site menu #1043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR: * adds search in switch site menu; * adds scroll in site list if it is very long; * removes switch site from account menu.
fflorent
suggested changes
Jun 14, 2024
There was a problem hiding this comment.
Thank you for this PR! I took a quick look, that seems to me already quite good! :)
I see that some tests are failing, maybe they have to be adapted.
I will take a closer look a bit later, especially I would like to see it in action and give screenshots / screencasts, to review the UX enhancement itself.
fflorent
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Looks good to me (sorry for the delay, please don't hesitate to mark me as a reviewer, so I can take see this PR on my list).
Could you rebase with the main branch? There has been some changes brought meanwhile, and it seems there exist conflicts.
If you need help or if you are bored with that, I can take a look to rebase properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: