HomeDBManager refactoration: extract method related to Users management in its own module

[fflorent]

Context

The HomeDBManager module is too big, it has too much responsibilities and it becomes hard to have a global vision of its methods.

Proposed solution

I extracted some methods related to users management and moved them in their own class: UsersManager. It's a first step for shrinking HomeDBManager.

The HomeDBManager remains the exposed class to the other parts of the code: any module under gen-server/lib/homedb like UsersManager is intended to be used solely by HomeDBManager, and in order to use their methods, an indirection has to be created to pass through HomeDBManager.

In a later PR, I'll propose to move HomeDBManager.ts to homedb/index.ts. I prefer deferring in order to remove noise and make small steps instead.

How to review?

I don't know whether Github has an option to see line moved across files. I found this trick which uses the git diff command:

$ git checkout refactor-homedb # or gh pr 1049
$ git diff --color-moved=zebra origin/main HEAD

Source: https://git-scm.com/docs/diff-options#Documentation/diff-options.txt---color-movedltmodegt

[hexaltation]

LGTM

[fflorent]

Thank you @hexaltation!

[paulfitz]

Thank you for wrestling with this beast @fflorent

[fflorent]

Thanks @paulfitz! The PR is not merged yet, do you expect something else beforehand?

[paulfitz]

Thanks @paulfitz! The PR is not merged yet, do you expect something else beforehand?

Thanks for reminder :)