Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdown: document this function #1142

Merged
merged 1 commit into from
Aug 5, 2024
Merged

markdown: document this function #1142

merged 1 commit into from
Aug 5, 2024

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented Jul 30, 2024

No description provided.

@paulfitz paulfitz added the preview Launch preview deployment of this PR label Jul 31, 2024
@paulfitz
Copy link
Member

(turning on a preview just to show recent changes to someone, sorry for noise)

@github-actions GitHub Actions
Copy link
Contributor

Deployed commit 1382d0500e791fefb12256bad0bdf11da9823724 as https://grist-gristlabs-grist-core-jordigh-document-markdown-function.fly.dev (until 2024-08-30T14:12:44.846Z)

@paulfitz paulfitz removed the preview Launch preview deployment of this PR label Jul 31, 2024
berhalak
berhalak requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

app/client/lib/markdown.ts Outdated Show resolved Hide resolved
@jordigh jordigh force-pushed the jordigh/document-markdown-function branch from 044c517 to 02128b1 Compare August 5, 2024 15:07
@jordigh jordigh force-pushed the jordigh/document-markdown-function branch from 02128b1 to 4019c88 Compare August 5, 2024 15:08
berhalak
berhalak approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

app/client/lib/markdown.ts Show resolved Hide resolved
@jordigh jordigh merged commit 4bfcbf2 into main Aug 5, 2024
6 of 11 checks passed
@jordigh jordigh deleted the jordigh/document-markdown-function branch August 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berhalak berhalak berhalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordigh @paulfitz @berhalak