support other SQLite wrappers, and various hooks needed by grist-static #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // dbstat compiled in. But it would be sad to disable | ||
| // Grist entirely just because we can't track byte-count. | ||
| // So return NaN in this case. | ||
| return {totalSize: NaN}; |
There was a problem hiding this comment.
At some point in the future, should we return something like null instead? I realize doing it now will introduce a bunch of type errors (and the doc usage UI would need to be updated too) - just wondering.
There was a problem hiding this comment.
Yes, that would be nice. But it could also be easy to make a SQLite build with dbstat enabled.
| if (sandboxProcess.dataFromSandboxDescriptor) { | ||
| this._streamFromSandbox = | ||
| (this.childProc.stdio as Stream[])[sandboxProcess.dataFromSandboxDescriptor]; | ||
| if (this.childProc) { |
There was a problem hiding this comment.
Any easy changes we can make here to simplify things? (e.g. splitting up into methods, lowering conditional depth)
Ok if not - just flagging because it was a bit of a struggle to read.
There was a problem hiding this comment.
I broke the constructor up somewhat.
paulfitz
force-pushed
the
grist-static-playground3
branch
from
e6f014a
to
f991c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grist-static currently uses a hacky patched version of grist-core. In this PR, I'm working on cleaning up the changes, and consolidating them in general-purpose hooks.
credentiallessis useful in some situations)realpathfunction orsetImmediatefunction