Visually identify that a field is a drop-down list (single choice) #491

[fflorent]

Fix #491, for single choice lists only.

Remaining TODO:

• Ensure it works well when the user only has read-only rights (seems to work just like the reference field);
• Deduplicate code when relevant (lots of copy-paste from ReferenceEditor ⇒ is this relevant to deduplicate?);
• Remove the chevron icon when editing from the table view (it should only appear in the detail view);

Help welcome for these questions 🙏:

• Does this enhancement deserve to write unit tests? I would say no, as it does not introduce new feature per se.
• Is it relevant to deduplicate the code from the Reference? It is mostly copy/paste of styles
• Currently the chevron icon is even shown in the Grid when triggering the editor. How would you do that? I am not sure how to manage to remove it:
  • That seems not being doable through CSS, as the editor does not descent from the GridView's HTML element;
  • That seems not being doable through JS, the editor instance is not aware of the view (DetailView, GridView, ...) from which the user has triggered it (and I would not think relevant storing the view in the editor);

Here is how it is rendered as of the current state of the PR:

record4.webm

[georgegevoian]

Thanks for opening the PR @fflorent.

To answer your questions:

1. I agree. If you really want to, you can update an existing browser test or two to check for the presence (or absence) of the dropdown icon, but since it's just a cosmetic change, I don't think it's that important to have a test for it.
2. I reviewed your changes and didn't see much duplication, so I think it's fine as is.
3. Both ChoiceEditor and ChoiceTextBox should have the field available to them, which itself has a viewSection. You can check what type of view you have by inspecting the parentKey of the view section; for example, a card view will have a value of "detail" for the parent key. (It's a bit arcane - sorry!)

[fflorent]

Thank you @georgegevoian for your hint! I could end up to remove the chevron in the grid view when in edition mode.

It seems the PR is not updated, despite having updated the source branch. I will take a look tomorrow to see what went wrong while updating the PR. (Edit : it took a little while, but the PR finally got synchronized 🤷)

Cheers!

[fflorent]

The PR got synchronized by itself! 🎉

[georgegevoian]

Any thoughts on whether we should also show the icon in card list views? They are very similar to card views, so it might be a good idea for the sake of consistency.

[georgegevoian]

Suggested change

cssChoiceEditIcon('Dropdown'),

The config DOM is what's shown in the right panel (with the editor for choice options), so we don't want to add the icon here.

[georgegevoian]

Still seeing this line in the latest revision.

[fflorent]

Weird, I thought that I have pushed the change… I fix that!

[fflorent]

I hope that's better now, thank you for your vigilance!

[fflorent]

Thanks @georgegevoian, I have taken into account your remarks! :)

[georgegevoian]

Thanks @fflorent!