skip building test harness in docker image #551
Conversation
|
The relevant docker build actions are here: https://github.com/gristlabs/grist-core/actions/workflows/docker_latest.yml |
A small test harness bundle was recently added that is breaking the docker image build. It could be added to the docker image, but that would introduce a bunch of extraneous test file dependencies. So this tweaks the build to simply skip the test bundle if its primary source file is not found.
paulfitz
force-pushed
the
paulfitz/omit-test-harness-from-docker-build
branch
from
ce096f5
to
3f959e3
Compare
|
Example of artifact on a failing run https://github.com/paulfitz/grist-core/actions/runs/5419990087 - could do with a better way to cross reference worker process number with mocha-webdriver output, and I'm not sure the mocha-webdriver textual output is complete, but that'll be for another PR. |
| document.getElementById('configure').innerHTML = 'called'; | ||
| }; | ||
| } | ||
| function setup() { |
There was a problem hiding this comment.
Do you know why that helped? It doesn't seem to change anything (and we have custom widgets that follow the previous pattern).
There was a problem hiding this comment.
This way, the setup is called only when the page has loaded and the elements it refers to exist. Previously, there was a race - if callbacks happened too early, elements like configure could be accessed before they existed.
A small test harness bundle was recently added that is breaking the docker image build. It could be added to the docker image, but that would introduce a bunch of extraneous test file dependencies. So this tweaks the build to simply skip the test bundle if its primary source file is not found.
Also added some other test fixes along the way:
ptexists