Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu fontfix liberation #573

Closed
wants to merge 2 commits into from
Closed

Ubuntu fontfix liberation #573

wants to merge 2 commits into from

Conversation

jvorob
Copy link
Contributor

@jvorob jvorob commented Jul 13, 2023

See #568

Switched font so that all things are in Liberation Sans, should look better and be less wide
(Previously was DejaVu Sans for most text and Liberation Sans only for data)

image

Currently, ubuntu has a lot of issues with fonts.
Both the regular font-family and the data-font-family end up
evaluating to NimbusSans on my system
  (ubuntu's fallback font from helvetica)

NimbusSans unfortunately is noticably too high, cause text in buttons,
emoji on the left pane, and other vertical text alignment to be too high

This diff explicitly says to use DejaVu and Liberation Sans which should
have no effect on windows/mac systems, but should significantly improve
appearance on ubuntu (and hopefully other linuxes)

Both of these fonts are some of the more widely supported linux fonts,
see:
https://www.webfx.com/blog/web-design/a-web-designers-guide-to-linux-fonts/
@jvorob jvorob added the preview Launch preview deployment of this PR label Jul 13, 2023
@github-actions
Copy link
Contributor

Deployed as https://grist-ubuntu-fontfix-liberation.fly.dev (until 2023-08-12T14:53:12.521Z)

@jvorob jvorob closed this Jul 13, 2023
@jvorob jvorob deleted the ubuntu-fontfix-liberation branch September 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Launch preview deployment of this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant