Linkstate refactor #609
Linkstate refactor #609
Conversation
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-03T18:28:46.734Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-04T01:35:08.733Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-04T01:38:08.071Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-04T03:13:29.821Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-04T03:32:32.394Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-04T04:58:54.984Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-04T05:21:14.672Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-04T07:17:55.969Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-06T15:49:39.412Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-06T16:11:33.612Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-06T16:32:16.696Z) |
jvorob
force-pushed
the
linkstate-refactor
branch
2 times, most recently
from
78c01cc
to
b78339f
Compare
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-07T16:08:42.671Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-07T16:14:25.270Z) |
|
Can you add tests for the bugs you have fixed? |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-20T23:02:11.574Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-21T07:11:59.098Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-09-21T07:22:29.692Z) |
Big refactor to LinkingState
pulls out descriptive/user-facing info into LinkingState
Adds Linkinfo to SelectBy/"Selector For" UI in right panel
Bugfix: Disables linking from Attachment columns
Bugfix/Behavior change: changed linking with empty RefLists to better
match behavior of refs.
(for context: Linking by a blank Ref filters to show records with a
blank value for that Ref)
Previously this didn't work with RefLists. Linking from a blank
refList would show no records (except in some cases involving summary
tables)
Fixed this so that linking by a blank val consistently means "show
all records where the corresponding col is blank"
Tweaks to buildViewSectionDom, widgetTitle DOM
previously the title dom element (testid('viewsection-title')) was
flex-grow 1, so all the blank space in the widget-title-row was part of
the title element (but only the actual title was clickable). This swaps
it so that the title doesn't grow, and instead the space is taken up by
a small div which stretches to fill available space. Makes it easier to
add other dom around the title
Fixed bug when lfilters=EmptyFilterState
Fixed computed leak on linkTypeDescription
Fixed "srcSection disposed" bug with linkTypeDescription
Fixed disposables in LinkingState: _update
Fixed imports (sorted, no relative paths)
Moved advancedLinkInfo isCollapsed into sessionObs
Indentation
Pulled out custom links into own if{} case
Removed spurious `owner` param in buildLinkInfo and co.
Css cleanup
Undid viewsection title flex fix
Changed all == to ===
Many comments, better explains linking logic
jvorob
force-pushed
the
linkstate-refactor
branch
from
f6f3afe
to
e6f4770
Compare
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-10-05T23:25:11.607Z) |
Previously, I only updated the _filterState computed once, but the intent was for the Computed of merged filters should update _filterState whenever it changed. This also led to a bug where summary-linking wouldn't work (only appeared to show up after rebasing onto latest main branch)
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-10-05T23:39:57.219Z) |
|
Deployed as https://grist-linkstate-refactor.fly.dev (until 2023-10-08T17:57:57.384Z) |
Big refactor to LinkingState
Adds Linkinfo to SelectBy/"Selector For" UI in right panel
Bugfix: Disables linking from Attachment columns
Bugfix/Behavior change: changed linking with empty RefLists to better match behavior of refs.
Tweaks to buildViewSectionDom, widgetTitle DOM
previously the title dom element (testid('viewsection-title')) was flex-grow 1, so all the blank space in the widget-title-row was part of the title element (but only the actual title was clickable). This swaps it so that the title doesn't grow, and instead the space is taken up by a small div which stretches to fill available space. Makes it easier to add other dom around the title