Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to add new CFN functions created since 2017. #15

Merged
merged 4 commits into from
Oct 27, 2022
Merged

Updating to add new CFN functions created since 2017. #15

merged 4 commits into from
Oct 27, 2022

Conversation

andylockran
Copy link
Contributor

Unsure if this is still well maintained, but added a few more functions needed to parse CFN schemas.

@andyloughran
Copy link

This should address #14

@andyloughran andyloughran mentioned this pull request Oct 27, 2022
Open
dsagal
dsagal reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good except one stray logging line.

index.js Outdated Show resolved Hide resolved
andylockran
andylockran commented Oct 27, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
andylockran
andylockran commented Oct 27, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
@andylockran
Copy link
Contributor Author

Resolved - thanks @dsagal

@dsagal dsagal merged commit bba9399 into gristlabs:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsagal dsagal dsagal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylockran @andyloughran @dsagal