-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eduroam database version 2 adaptation #62
Comments
From mobility day, reporting on the recent GeGC meeting:
|
Short notice : |
Thanks, I never considered that.
Except that the server has no way of knowing what version is requested. |
Hi @zmousm , have you already started looking at implementing this? Wondering whether to dive into it myself. Would you know whether this would also need changes to the underlying data model, or whether we have all the information required to construct the right format in a view? Cheers, |
Hi @vladimir-mencl-eresearch. Yes I have (had), more than once. My patch set is half-baked so it is not pushed yet. I currently need to rebase on top of the final PY3 changes. Changes to the models are necessary and unavoidable, as I tried to elaborate previously. It would really help if you could cast your preference, providing arguments from a Django perspective, how to deal with the open questions and caveats, namely modeling coordinates. |
I had second thoughts about modeling coordinates, triggered after realizing that class Coordinates(models.Model):
previous = models.OneToOneField("self", null=True, blank=True,
related_name="next")
content_type = models.ForeignKey(ContentType, blank=True, null=True)
object_id = models.PositiveIntegerField(blank=True, null=True)
content_object = fields.GenericForeignKey('content_type', 'object_id')
class Meta:
unique_together = ((..., 'previous', 'content_type', 'object_id'),) The first instance in a chain (or the single instance otherwise) would get |
eduroam db v2 schema changes
[realm]
[institution]
[service_loc]
eduroam db v2 schema caveats
we use for mapping because django does not allow tuples with len > 2 to be used for choices
of the street, city fields, which does not make sense; we shall have to transform as necessary
However it would never yield 0 (mobile) because service_loc requires number of coordinates >= 1
In other words: does it make sense for a service_loc type=mobile to have any coordinates?
realm->ro and json endpoints); if multiple versions are supported (backwards compat), a setting must define which version should be rendered
coordinates database modeling
djnro models changes
Contact
Address_i18n (new model)
Realm
Institution
InstitutionDetails
ServiceLoc
RealmData
djnro data migrations
djnro models cleanup
Realm
InstitutionDetails
ServiceLoc
TBA: forms, views, templates
The text was updated successfully, but these errors were encountered: