mqtt subscribing to private path had a small bug #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be reviewed? It resolves #19 |
yuma-m
reviewed
Jun 20, 2020
src/mqtt_bridge/mqtt_client.py
Outdated
| @@ -56,6 +56,7 @@ def default_mqtt_client_factory(params): | |||
| def create_private_path_extractor(mqtt_private_path): | |||
| def extractor(topic_path): | |||
| if topic_path.startswith('~/'): | |||
| rospy.logdebug('{}/{}'.format(mqtt_private_path, topic_path[2:])) | |||
There was a problem hiding this comment.
@kapilPython kapilPythonCould you remove this line?
|
Hi @kapilPython, Thank you for your contribution. Your changes look good, could you kindly confirm the comment I added? |
yuma-m
reviewed
Jun 20, 2020
rospy.logdebug command could be removed this was just added to debug the changes. Co-authored-by: Yuma Mihira <yuma-m@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Topic to which the mqtt is subscribing in MqttToRosBridge is wrong with respect to the condition of private path. It should use the member variable _topic_from because that has the private path extracted topic name.