Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up tests by eliminating mandatory 0.2 second wait #203

Closed
wants to merge 2 commits into from
Closed

Speed up tests by eliminating mandatory 0.2 second wait #203

wants to merge 2 commits into from

Conversation

zdrve
Copy link
Collaborator

@zdrve zdrve commented Oct 3, 2022

Will also speed up "production" usage of Progress.progress, but since it's an average of 0.1 seconds per invocation, it won't be much there, proportionally.

grosser
grosser reviewed Oct 3, 2022
View reviewed changes
Copy link
Owner

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell if this is correct in all cases, will take another look later.
The "wake up when done" is nice though.

@grosser grosser mentioned this pull request Oct 4, 2022
Merged
@zdrve
Copy link
Collaborator Author

zdrve commented Oct 6, 2022

:-(

@zdrve zdrve closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grosser grosser grosser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdrve @grosser