Wrap update details in a collapsible group #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Mar 2, 2024
| @@ -22,11 +22,19 @@ def print(plan) | |||
|
|
|||
| def print_changes(step, list, color) | |||
| return if list.empty? | |||
|
|
|||
| use_groups = ENV.key?("GITHUB_STEP_SUMMARY") | |||
There was a problem hiding this comment.
Suggested change
| use_groups = ENV.key?("GITHUB_STEP_SUMMARY") | |
| use_groups = ENV.key?("GITHUB_STEP_SUMMARY") && item.class::TYPE == :update |
grosser
reviewed
Mar 2, 2024
| @@ -239,6 +240,19 @@ def change(*args) | |||
| TEXT | |||
| end | |||
|
|
|||
| it "wraps in a group, if running under GitHub" do | |||
There was a problem hiding this comment.
Suggested change
| it "wraps in a group, if running under GitHub" do | |
| it "wraps in a group to prevent big dumps like dashboard from making things unreadable, if running under GitHub" do |
|
v1.149.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ci-and-update output, the details of every changed field, especially for dashboards, can be very large – and that's especially annoying if it's just noise, because they're not your dashboards.
Wrap the update fields in a
::group::so that they can be collapsed.https://github.com/zendesk/kennel/actions/runs/8121982186/job/22200952160?pr=22287#step:7:2334
Checklist
path:in Gemfile)