Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: check for NoneType in OSM Connector #124

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Bugfix: check for NoneType in OSM Connector #124

merged 1 commit into from
Mar 1, 2018

Conversation

ialokim
Copy link
Contributor

@ialokim ialokim commented Feb 14, 2018

In case of invalid osm objects, OSMConnector returns None, but always expects a valid Line or Itinerary object. This PR should fix this.

@pantierra
Copy link
Contributor

pantierra commented Feb 25, 2018

Maybe it would be good to get a suitable error or warning message. In which cases has this happened? What would be a good warning or error message?

@ialokim
Copy link
Contributor Author

ialokim commented Feb 26, 2018

Maybe it would be good to get a suitable error or warning message. In which cases has this happened?

The subfunctions already print these warning messages out, see line 365 and line 296. So there's no need to add another message, only to handle the NoneType correctly.

Copy link
Contributor

@pantierra pantierra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pantierra pantierra added the bug label Feb 28, 2018
@grote grote merged commit 3a1ece5 into grote:master Mar 1, 2018
@ialokim ialokim deleted the osm-connector-none-fix branch March 1, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants