Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding errors #125

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Fix encoding errors #125

merged 1 commit into from
Feb 26, 2018

Conversation

ialokim
Copy link
Contributor

@ialokim ialokim commented Feb 15, 2018

While working on the countrywide NicaraguaCreator, I've found some odd python 2 encoding errors:

  • transitfeed's validator expects route_long_name and route_short_name to have the same encoding. That's why I changed the RoutesCreator.
  • str expects only ASCII values, if the route_id contains non-ASCII chars, it throws an error. These are the changes to TripsCreator.

This PR should fix them both.

@ialokim ialokim mentioned this pull request Feb 16, 2018
Open
pantierra
pantierra approved these changes Feb 25, 2018
View reviewed changes
Copy link
Contributor

@pantierra pantierra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@grote
Copy link
Owner

grote commented Feb 26, 2018

Thanks for spotting and the fix!

@grote grote merged commit d397f1b into grote:master Feb 26, 2018
@ialokim ialokim deleted the unicode-fix branch February 26, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pantierra pantierra pantierra approved these changes

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialokim @grote @pantierra