Add acceptance tests for Gran Area Metropolitana, Costa Rica #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2018
Closed
|
Updated based on latest upstream. Now this PR only includes the respective commit and is easier to review, for your convenience. |
Closed
|
@jamescr somebody nice made tests for your creator :) Do you want to review them? |
|
Rebased on current |
Co-authored-by: jamescr <jaime.cr@gmail.com>
|
This PR still needs a review. Can anybody please approve? Then we can merge it in and have all creators covered by tests 🎉 |
jamescr
approved these changes
Feb 1, 2020
|
@xamanu thanks! |
|
I will make a review |
nlehuby
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #134. It introduces a non-regression, acceptance tests for the Costa Rican provider. A review of the owner of the creator (@jamescr) is highly appreciated and a precondition to get this merged in.