Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-1272: Pin version of CircleCI Node image to 11.6.0 #64

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Conversation

jmbtutor
Copy link
Contributor

@jmbtutor jmbtutor commented Jan 24, 2019

This pins the version of node to 11.6.0 and yarn 1.12.3. node 11.7.0 or yarn 1.13.0 causes nyc to report 0% coverage.

istanbuljs/nyc#921
yarnpkg/yarn#6746

circleci/node:11.6.0
Digest: sha256:1a3a10a092bdfa3d92d48850818a5526b5770a58592156f6f8e6a5f7d946ac43
Created 2019-01-18T00:14:29.784667795Z
NODE_VERSION=11.6.0
YARN_VERSION=1.12.3

This pins the version of yarn to 1.12.3. yarn 1.13.0 causes nyc to
report 0% coverage.

circleci/node:11.6.0
Digest: sha256:1a3a10a092bdfa3d92d48850818a5526b5770a58592156f6f8e6a5f7d946ac43
Created 2019-01-18T00:14:29.784667795Z
NODE_VERSION=11.6.0
YARN_VERSION=1.12.3
Copy link
Contributor

@JoeyDeol JoeyDeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should keep an eye out for when the next version of yarn addresses this bug.

@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #64 into master will increase coverage by 93.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #64       +/-   ##
===========================================
+ Coverage       0%   93.96%   +93.96%     
===========================================
  Files          35      206      +171     
  Lines         287     5688     +5401     
  Branches       51      709      +658     
===========================================
+ Hits            0     5345     +5345     
+ Misses        287      250       -37     
- Partials        0       93       +93
Impacted Files Coverage Δ
...ackages/@storefront/core/src/core/service/index.ts 100% <0%> (ø)
packages/@storefront/structure/src/pages/index.ts 100% <0%> (ø)
...front/flux-capacitor/src/core/sagas/refinements.ts 96.87% <0%> (ø)
...ckages/@storefront/core/src/core/tag/decorators.ts 82.5% <0%> (ø)
...ront/core/src/core/url-beautifier/search/parser.ts 98.57% <0%> (ø)
...ront/products/src/swatch-variant-controls/index.ts 100% <0%> (ø)
packages/@storefront/core/src/services/search.ts 100% <0%> (ø)
...ges/@storefront/navigation/src/refinement/index.ts 100% <0%> (ø)
...s/@storefront/core/src/core/tag/mixins/metadata.ts 50% <0%> (ø)
packages/@storefront/core/src/services/redirect.ts 100% <0%> (ø)
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308ac2a...d637f15. Read the comment docs.

@jmbtutor jmbtutor merged commit 2d36b5f into master Jan 24, 2019
@jmbtutor jmbtutor deleted the SF-1272 branch January 24, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants