Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the method projectOnFace when the gradient fall on an edge #40

Closed
wants to merge 2 commits into from

Conversation

maher-nasr
Copy link
Member

  • the gradient projection is no longer done by taking the minimum angle between gradient vector and its projection. The local gradient at the cell scale is used to determine which face is to consider.
  • Many tests are removed to speed up the method.
  • Use the head wave traveltimes when the gradient projection points outside the tested edges.
    Enhance the projectOnFace method

Copy link
Member

@bernard-giroux bernard-giroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Maher,

I find only 1 change in the pull request (file boost_1_72_0/boost/asio/detail/throw_exception.hpp deleted, commit d45640a), which is not related to projectOnFace. I have no issue compiling with this file in the build tree... Please undo commit d45640a and verify your installation. Also commit the changes to projectOnFace

@maher-nasr
Copy link
Member Author

maher-nasr commented May 1, 2021 via email

@maher-nasr maher-nasr closed this May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants