Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header option leak #78

Merged
merged 4 commits into from
Nov 27, 2017
Merged

Fix header option leak #78

merged 4 commits into from
Nov 27, 2017

Conversation

jkrems
Copy link
Collaborator

@jkrems jkrems commented Nov 25, 2017 •
edited
Loading

  • The test suite on master doesn't pass right now because the CA certificate expired. Replacing this with ad-hoc certificates will prevent this problem for the future.
  • Fixes an issue where headers are actually written into the client's defaults if the defaults already include a headers option.
  • Use a smaller reddit API endpoint in the tests.

Don't be confused by the order of the commits. It does reflect the order in which the code was written, not the commit ordering in the final rebase. That's what I get for writing the tests first but then reordering to be more bisect-friendly...

dbushong
dbushong approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@dbushong dbushong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it

@jkrems jkrems merged commit d4d58f4 into master Nov 27, 2017
@jkrems jkrems deleted the jk-fix-header-leak branch November 27, 2017 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbushong dbushong dbushong approved these changes

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkrems @dbushong @i-tier-bot