Ignore searchDomain for localhost and IP #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will also backport to |
dbushong
reviewed
Mar 29, 2018
.eslintrc
Outdated
| "extends": "groupon/es5", | ||
| "rules": { | ||
| "prefer-arrow-callback": 0 | ||
| } |
There was a problem hiding this comment.
oops. looks like we need to fix that in groupon/javascript
There was a problem hiding this comment.
Porting: groupon/javascript#27
dbushong
reviewed
Mar 29, 2018
| throw new Error('Invalid URI ' + JSON.stringify(hostname)); | ||
| } | ||
| if (searchDomain && canApplySearchDomain(hostname)) { | ||
| return hostname + '.' + searchDomain + '.'; |
There was a problem hiding this comment.
Do we want to force searchDomain to be absolute, or should we let people specify it as my.tld. if they want it to be so?
There was a problem hiding this comment.
I guess that would be a breaking change
dbushong
approved these changes
Mar 29, 2018
jkrems
force-pushed
the
jk-less-aggressive-search-domain
branch
from
489377f
to
8cfb230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how this stayed un-fixed for so long.