Add gofer.getMergedOptions #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
force-pushed
the
jkrems/feature/master/public-prepare-options-3x
branch
from
df51989
to
fb9809e
Compare
dbushong
reviewed
Oct 4, 2018
| @@ -114,13 +123,14 @@ Gofer.prototype._prepareOptions = function _prepareOptions(defaults, options) { | |||
| options, | |||
| preventComplexMerge | |||
| ); | |||
| delete mergedOptions.endpointDefaults; | |||
There was a problem hiding this comment.
Is this supposed to be .endpointName ?
There was a problem hiding this comment.
This removes all the other endpointDefaults that do not apply to the selected options. This way it's limited to what would actually have an effect. It's an attempt of reducing the amount of internals this leaks.
There was a problem hiding this comment.
Removing endpointName here would break reporting because we do rely on that setting surviving and making it into our instrumentation layer.
dbushong
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an official way to get the effective options, given some defaults and/or overrides.