Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry.from() #9

Merged
merged 3 commits into from
May 28, 2019
Merged

Registry.from() #9

merged 3 commits into from
May 28, 2019

Conversation

dbushong
Copy link
Member

I'm on the fence as to whether this is worth it. There's currently a lot of boilerplate to test an individual object-graph.js file, e.g., and this feels like it might streamline it a bit. The boilerplate is in the latter section of the example added to the README - note that it's actually a bit messier than that now, because you have to say something like .getActionInjector({}, {}, {})

  • chore: npm audit fix
  • feat: add Registry.from()
  • refactor: typofix variable name

This PR was started by: git wf pr

Copy link

@markowsiak markowsiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 🚢

@jkrems
Copy link
Collaborator

jkrems commented May 27, 2019

Nice!

(Also, sorry for that typo)

Copy link
Member

@aotarola aotarola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚 neato

@dbushong dbushong changed the title [WIP] Registry.from() Registry.from() May 28, 2019
@dbushong dbushong merged commit 62e3d8f into master May 28, 2019
@dbushong dbushong deleted the dbushong/feature/master/registry-from branch May 28, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants