Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for vecsize & columns fields #142

Merged
merged 6 commits into from
Apr 27, 2020
Merged

Support for vecsize & columns fields #142

merged 6 commits into from
Apr 27, 2020

Conversation

sir-earl
Copy link
Contributor

No description provided.

@sir-earl sir-earl changed the title Added support for vecsize & columns fields Support for vecsize & columns fields Apr 26, 2020
@sir-earl sir-earl mentioned this pull request Apr 26, 2020
Closed
grovesNL
grovesNL reviewed Apr 26, 2020
View reviewed changes
Copy link
Owner

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

spirv_cross/src/compiler.rs Outdated Show resolved Hide resolved
grovesNL
grovesNL approved these changes Apr 27, 2020
View reviewed changes
Copy link
Owner

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Apr 27, 2020

Build succeeded:

@bors bors bot merged commit bf9d07a into grovesNL:master Apr 27, 2020
@sir-earl sir-earl deleted the vecsize-support branch April 27, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlendp erlendp erlendp left review comments

@grovesNL grovesNL grovesNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sir-earl @grovesNL @erlendp