Fix sticky bucket tests

growthbook · Apr 6, 2024 · 5fe1249 · 5fe1249
1 parent bb08508
commit 5fe1249
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/growthbook.py b/growthbook.py
@@ -428,8 +428,8 @@ def __init__(
         self.name = name
         self.phase = phase
         self.disableStickyBucketing = disableStickyBucketing
-        self.bucketVersion = bucketVersion
-        self.minBucketVersion = minBucketVersion
+        self.bucketVersion = bucketVersion or 0
+        self.minBucketVersion = minBucketVersion or 0
         self.parentConditions = parentConditions
 
         self.fallbackAttribute = None
@@ -645,8 +645,8 @@ def __init__(
         self.name = name
         self.phase = phase
         self.disableStickyBucketing = disableStickyBucketing
-        self.bucketVersion = bucketVersion
-        self.minBucketVersion = minBucketVersion
+        self.bucketVersion = bucketVersion or 0
+        self.minBucketVersion = minBucketVersion or 0
         self.parentConditions = parentConditions
 
     def to_dict(self) -> dict:
@@ -1418,15 +1418,16 @@ def _run(self, experiment: Experiment, featureId: Optional[str] = None) -> Resul
                 experiment.bucketVersion
             )] = result.key
 
-            doc = self._generate_sticky_bucket_assignment_doc(
+            data = self._generate_sticky_bucket_assignment_doc(
                 hashAttribute,
                 hashValue,
                 assignment
             )
-            if doc.get('changed', False):
+            doc = data.get("doc", None)
+            if doc and data.get('changed', False):
                 if not self.sticky_bucket_assignment_docs:
                     self.sticky_bucket_assignment_docs = {}
-                self.sticky_bucket_assignment_docs[doc.get('key')] = doc 
+                self.sticky_bucket_assignment_docs[data.get('key')] = doc
                 self.sticky_bucket_service.save_assignments(doc)
 
         # 14. Fire the tracking callback if set

diff --git a/tests/test_growthbook.py b/tests/test_growthbook.py
@@ -162,9 +162,11 @@ def test_stickyBucket(stickyBucket_data):
     gb = GrowthBook(**ctx)
     res = gb.eval_feature(key)
 
-    assert res.experimentResult != None
+    if not res.experimentResult:
+      assert None == expected_result
+    else:
+        assert res.experimentResult.to_dict() == expected_result
 
-    assert res.experimentResult.to_dict() == expected_result
     assert gb.get_sticky_bucket_assignment_docs() == expected_docs