Feature/add error handler for callback #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension refreshCallback
Extension refresh callback
tinahollygb
reviewed
Jul 11, 2023
lib/src/main/java/growthbook/sdk/java/GBFeaturesRepository.java
Outdated
Show resolved
Hide resolved
tinahollygb
reviewed
Jul 11, 2023
lib/src/main/java/growthbook/sdk/java/GBFeaturesRepository.java
Outdated
Show resolved
Hide resolved
tinahollygb
reviewed
Jul 11, 2023
lib/src/main/java/growthbook/sdk/java/GBFeaturesRepository.java
Outdated
Show resolved
Hide resolved
tinahollygb
reviewed
Jul 11, 2023
lib/src/main/java/growthbook/sdk/java/GBFeaturesRepository.java
Outdated
Show resolved
Hide resolved
tinahollygb
reviewed
Jul 11, 2023
lib/src/main/java/growthbook/sdk/java/GBFeaturesRepository.java
Outdated
Show resolved
Hide resolved
tinahollygb
reviewed
Jul 11, 2023
lib/src/main/java/growthbook/sdk/java/GBFeaturesRepository.java
Outdated
Show resolved
Hide resolved
tinahollygb
suggested changes
Jul 11, 2023
Co-authored-by: Tina Holly <113377031+tinahollygb@users.noreply.github.com>
Thank you, I was glad to contribute) I added 2 more tests to check refresh callback. |
tinahollygb
reviewed
Jul 12, 2023
lib/src/test/java/growthbook/sdk/java/GBFeaturesRepositoryTest.java
Outdated
Show resolved
Hide resolved
tinahollygb
suggested changes
Jul 14, 2023
tinahollygb
reviewed
Jul 19, 2023
lib/src/test/java/growthbook/sdk/java/GBFeaturesRepositoryTest.java
Outdated
Show resolved
Hide resolved
tinahollygb
reviewed
Jul 25, 2023
lib/src/test/java/growthbook/sdk/java/GBFeaturesRepositoryTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 2, 2023 11:16
…dler-for-callback # Conflicts: # lib/src/main/java/growthbook/sdk/java/GBFeaturesRepository.java
tinahollygb
approved these changes
Aug 2, 2023
|
Awesome, thanks for the contribution! 🚀 |
Glad to take part) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. We want to use client-side Growthbook service call metrics. But a handler made for succesfully calls only would like to add an error handler as well. Here's the pull request, it's not claims to be the best solution. Thank you)
Closes #32