Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve evalFeature performance: generate fewer MalformedURLException #35

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Improve evalFeature performance: generate fewer MalformedURLException #35

merged 1 commit into from
Jul 19, 2023

Conversation

crinklywrappr
Copy link
Contributor

Resolve #34

@crinklywrappr crinklywrappr changed the title utils: return null if urlString is null or empty Improve evalFeature performance: generate fewer MalformedURLException Jul 19, 2023
tinahollygb
tinahollygb approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@tinahollygb tinahollygb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@tinahollygb tinahollygb merged commit 97ca6ab into growthbook:main Jul 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinahollygb tinahollygb tinahollygb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spend less time generating MalformedUrlException
2 participants
@crinklywrappr @tinahollygb