Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env var for API rate limit max #1386

Merged
merged 2 commits into from
Jun 23, 2023
Merged

add env var for API rate limit max #1386

merged 2 commits into from
Jun 23, 2023

Conversation

itsgrimetime
Copy link
Contributor

Features and Changes

Adds an environment variable to allow configuring API rate limit max

Dependencies

N/A

Testing

  1. Run locally w/ yarn:dev
  2. Login & create API key
  3. run something like time while true do; curl ...; done in a loop on any API endpoint to see rate limiting occuring after some time
  4. set API_RATE_LIMIT_MAX env var and restart backend app
  5. repeat step 3 and see that it takes... longer :)

Screenshots

@jdorn jdorn merged commit ec647ad into growthbook:main Jun 23, 2023
@jdorn
Copy link
Member

jdorn commented Jun 23, 2023

Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants