Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stats] Fix idtype join for RA metrics #1406

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[stats] Fix idtype join for RA metrics #1406

merged 1 commit into from
Jun 27, 2023

Conversation

lukesonnet
Copy link
Collaborator

Features and Changes

Mistakenly hardcoded user_id instead of baseIdType for the RA join.

Testing

Test integration queries don't change at all (as all use user_id, should fix later)

@lukesonnet lukesonnet merged commit 0b8c7f5 into main Jun 27, 2023
@lukesonnet lukesonnet deleted the lsonnet/ra_sql_fix branch June 27, 2023 16:46
@github-actions
Copy link

Your preview environment pr-1406-bttf has been deployed with errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdorn jdorn jdorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukesonnet @jdorn