Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-swagger: add default error response #1127

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

johanbrandhorst
Copy link
Collaborator

Adds a "default" error entry to all responses
in the swagger definitions.

Fixes #1122

I can't think of a reason why this wouldn't be backwards compatible.

@johanbrandhorst johanbrandhorst force-pushed the swagger-add-default-error-response branch 2 times, most recently from eda0987 to 305ab34 Compare February 10, 2020 12:38
Adds a "default" error entry to all responses
in the swagger definitions.

Fixes #1122
@johanbrandhorst johanbrandhorst force-pushed the swagger-add-default-error-response branch from 305ab34 to 824f19a Compare February 10, 2020 12:46
@codecov-io
Copy link

Codecov Report

Merging #1127 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
+ Coverage   53.68%   53.87%   +0.18%     
==========================================
  Files          42       42              
  Lines        4187     4197      +10     
==========================================
+ Hits         2248     2261      +13     
+ Misses       1692     1689       -3     
  Partials      247      247
Impacted Files Coverage Δ
runtime/errors.go 49.31% <100%> (+1.94%) ⬆️
protoc-gen-swagger/genswagger/template.go 56.88% <100%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a127c...824f19a. Read the comment docs.

Copy link
Collaborator

@achew22 achew22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have some knock on implications for Bazel, but it's totally fine. I'll deal with it once this is merged.

@johanbrandhorst johanbrandhorst merged commit b4a970d into master Feb 10, 2020
@johanbrandhorst johanbrandhorst deleted the swagger-add-default-error-response branch February 10, 2020 20:20
@seanlaff
Copy link
Contributor

@johanbrandhorst Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated spec missing grpc errors
5 participants