Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http2 dependency to pick up fix for sending trailers with endOfStream set #13

Closed
jakobr-google opened this issue Jun 29, 2017 · 0 comments · Fixed by #21
Closed

Update http2 dependency to pick up fix for sending trailers with endOfStream set #13

jakobr-google opened this issue Jun 29, 2017 · 0 comments · Fixed by #21
Assignees
@jakobr-google
Labels
type-work-item

Comments

@jakobr-google
Copy link
Contributor

Upgrade package:http2 dependency once a release containing dart-lang/http2#8 is available.
@jakobr-google jakobr-google self-assigned this Jun 29, 2017
@jakobr-google jakobr-google mentioned this issue Jul 4, 2017
Closed
jakobr-google added a commit to jakobr-google/grpc-dart that referenced this issue Jul 6, 2017
@jakobr-google
Upgrade package:http2 dependency.
1fb961f 
Picks up fix for sending endStream bit on the requested frame, instead
of on an empty data frame following it.

Needed for interoperability with the Go gRPC client, since it otherwise
failed to recognize the trailer frame sent from the server.

Fixes grpc#13.
@jakobr-google jakobr-google mentioned this issue Jul 6, 2017
Merged
jakobr-google added a commit that referenced this issue Jul 6, 2017
@jakobr-google
Upgrade package:http2 dependency. (#21)
aefc45c 
Picks up fix for sending endStream bit on the requested frame, instead
of on an empty data frame following it.

Needed for interoperability with the Go gRPC client, since it otherwise
failed to recognize the trailer frame sent from the server.

Fixes #13.
@Xyzcancer Xyzcancer mentioned this issue May 27, 2021
Closed
@guyluz11 guyluz11 mentioned this issue Jun 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobr-google jakobr-google

Labels
type-work-item
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade package:http2 dependency. jakobr-google/grpc-dart
2 participants
@mit-mit @jakobr-google