Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump http version from 0.13.0 to 1.0.0 #629

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Bump http version from 0.13.0 to 1.0.0 #629

merged 4 commits into from
Jun 16, 2023

Conversation

ghatdev
Copy link
Contributor

@ghatdev ghatdev commented May 24, 2023

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 24, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@domesticmouse domesticmouse requested a review from kevmoo May 24, 2023 14:57
@domesticmouse
Copy link
Contributor

@kevmoo is Dart 2.17.0 intentional, or should the CI be moved to Dart stable and Dart beta.

@kevmoo
Copy link
Contributor

kevmoo commented May 24, 2023

@domesticmouse – we should have CI set to the oldest supported SDK

@kevmoo
Copy link
Contributor

kevmoo commented May 24, 2023

We should have a WIDE constraint on pkg:http – there were no breaks AFAIK

@cachapa cachapa mentioned this pull request May 27, 2023
Closed
kevmoo
kevmoo reviewed May 30, 2023
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
kevmoo
kevmoo reviewed May 31, 2023
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
kevmoo
kevmoo requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change - for the changelog, please!

pubspec.yaml Show resolved Hide resolved
@ghatdev @kevmoo
Bump http version from 0.13.0 to 1.0.0
6c3721b 
Update pubspec.yaml

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>

Bump actions/checkout from 3.5.0 to 3.5.2 (grpc#626)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.0 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8f4b7f8...8e5e7e5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Regenerate code with latest formatter (grpc#630)

Update pubspec.yaml

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jun 1, 2023
@ghatdev
Copy link
Contributor Author

ghatdev commented Jun 1, 2023

@kevmoo Is this will be O.K?

@domesticmouse
Copy link
Contributor

@kevmoo Is this will be O.K?

Please update the CHANGELOG.md file to mention this change. You can use NEXT as the version that will include the change.

@domesticmouse
Copy link
Contributor

Oh wait, it looks like the CI on this repo is set to publish on commit, and really doesn't like the version NEXT in the change log.

@kevmoo any preference on what the new version should be?

@kevmoo
Copy link
Contributor

kevmoo commented Jun 16, 2023

3.2.1 is great!

@ghatdev
Copy link
Contributor Author

ghatdev commented Jun 16, 2023

@kevmoo @domesticmouse I just set the version to 3.2.1

@domesticmouse domesticmouse merged commit 1f8d992 into grpc:master Jun 16, 2023
@broderix broderix mentioned this pull request Jun 16, 2023
Closed
@domesticmouse
Copy link
Contributor

@kevmoo any idea how to get this published?

@kevmoo
Copy link
Contributor

kevmoo commented Jun 17, 2023

I have the keys!

@mraleph
Copy link
Member

mraleph commented Jun 19, 2023

@kevmoo you forgot to create a release... also there is a publishing workflow through actions (https://github.com/grpc/grpc-dart/blob/master/.github/workflows/publish.yaml) so you don't need to manually publish.

@kevmoo
Copy link
Contributor

kevmoo commented Jun 19, 2023

I don't have admin access to this repo – so the publish action was broken for me.

@devoncarew devoncarew mentioned this pull request Jun 21, 2023
Closed
@amondnet amondnet mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghatdev @domesticmouse @kevmoo @mraleph