Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add launchd configuration to support brew services #1

Closed
wants to merge 1 commit into from
Closed

add launchd configuration to support brew services #1

wants to merge 1 commit into from

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Mar 13, 2017

Add a launchd configuration so that brew services can manage a
single-node Cockroach cluster, if so desired.

Add a launchd configuration so that brew services can manage a
single-node Cockroach cluster, if so desired.
Copy link
Contributor

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should close cockroachdb/cockroach#9438

also, why is this repo private? seems to defeat the purpose.

cockroach start --store=#{var}/cockroach
plist_options :manual => "cockroach start"

def plist; <<-EOS.undent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the semicolon instead of a newline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Homebrew style, for whatever reason. To save a level of indentation, I think.

@benesch
Copy link
Contributor Author

benesch commented Mar 13, 2017

Ooo, thanks for the pointer. After reading that issue, I'm going to hold off on this until we have a less-contentious HTTP port. @bdarnell do you have thoughts here? Perhaps 26256, one below the default Cockroach port?

We also need to decide if letting brew services start cockroach launch an insecure cluster is acceptable.

@bdarnell
Copy link
Contributor

After reading that issue, I'm going to hold off on this until we have a less-contentious HTTP port. @bdarnell do you have thoughts here? Perhaps 26256, one below the default Cockroach port?

We're not going to get a second officially-allocated port, so whatever we do will just be squatting on some unclaimed port. 26256 is as good as any.

@tamird Is there any update on the feasibility of merging the HTTP port back onto the GRPC port? The use of 8080 was supposed to be temporary.

We also need to decide if letting brew services start cockroach launch an insecure cluster is acceptable.

What do other brew services do? This is opt-in and not just a consequence of brew install, right? If it's opt-in I'm slightly more OK with it as long as it's restricted to localhost-only (although it would be even better if we could generate a set of keys the first time the service is started)

@tamird
Copy link
Contributor

tamird commented Mar 13, 2017

@tamird Is there any update on the feasibility of merging the HTTP port back onto the GRPC port? The use of 8080 was supposed to be temporary.

Well, the grpc fork at https://github.com/bradfitz/grpc-go only supports the ServeHTTP path (this is the one that would let us merge the ports back) but I'm quite sure there hasn't been any performance work on mainline to make that any more feasible. See https://github.com/cockroachdb/rpc-bench for slightly dated results (I can update if you'd like).

TL;DR there's no update, but it's still something we hope to do.

@bdarnell
Copy link
Contributor

Let's rerun the benchmarks and ping grpc/grpc-go#586 again. Managing the two ports is going to be an ongoing headache for deployments so it would be great if we could resolve it before 1.0.

@tamird
Copy link
Contributor

tamird commented Mar 15, 2017

@bdarnell done.

@benesch benesch changed the base branch from master to dummy March 31, 2017 00:50
@benesch benesch changed the base branch from dummy to master March 31, 2017 00:51
@benesch
Copy link
Contributor Author

benesch commented Mar 31, 2017

This is inexplicably stuck on an old commit. Revised by #6.

@benesch benesch closed this Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants