-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add launchd configuration to support brew services #1
Conversation
Add a launchd configuration so that brew services can manage a single-node Cockroach cluster, if so desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should close cockroachdb/cockroach#9438
also, why is this repo private? seems to defeat the purpose.
cockroach start --store=#{var}/cockroach | ||
plist_options :manual => "cockroach start" | ||
|
||
def plist; <<-EOS.undent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the semicolon instead of a newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Homebrew style, for whatever reason. To save a level of indentation, I think.
Ooo, thanks for the pointer. After reading that issue, I'm going to hold off on this until we have a less-contentious HTTP port. @bdarnell do you have thoughts here? Perhaps 26256, one below the default Cockroach port? We also need to decide if letting |
We're not going to get a second officially-allocated port, so whatever we do will just be squatting on some unclaimed port. 26256 is as good as any. @tamird Is there any update on the feasibility of merging the HTTP port back onto the GRPC port? The use of 8080 was supposed to be temporary.
What do other brew services do? This is opt-in and not just a consequence of |
Well, the grpc fork at https://github.com/bradfitz/grpc-go only supports the ServeHTTP path (this is the one that would let us merge the ports back) but I'm quite sure there hasn't been any performance work on mainline to make that any more feasible. See https://github.com/cockroachdb/rpc-bench for slightly dated results (I can update if you'd like). TL;DR there's no update, but it's still something we hope to do. |
Let's rerun the benchmarks and ping grpc/grpc-go#586 again. Managing the two ports is going to be an ongoing headache for deployments so it would be great if we could resolve it before 1.0. |
@bdarnell done. |
This is inexplicably stuck on an old commit. Revised by #6. |
Add a launchd configuration so that brew services can manage a
single-node Cockroach cluster, if so desired.