Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated functions #6782

Closed
dfawley opened this issue Nov 10, 2023 · 4 comments · Fixed by #6907 or #6911
Closed

Remove use of deprecated functions #6782

dfawley opened this issue Nov 10, 2023 · 4 comments · Fixed by #6907 or #6911
Assignees

Comments

@dfawley
Copy link
Member

dfawley commented Nov 10, 2023

https://pkg.go.dev/net/http#CloseNotifier

$ grep -r CloseNotifier
internal/transport/handler_server_test.go:				type onlyCloseNotifier interface {
internal/transport/handler_server_test.go:					http.CloseNotifier
internal/transport/handler_server_test.go:				return struct{ onlyCloseNotifier }{w.(onlyCloseNotifier)}

https://pkg.go.dev/crypto/x509#CertPool.Subjects

$ grep -r Roots.Subjects
credentials/tls/certprovider/store_test.go:	if gotR, wantR := got.Roots.Subjects(), want.Roots.Subjects(); !cmp.Equal(gotR, wantR, cmpopts.EquateEmpty()) {
credentials/tls/certprovider/pemfile/watcher_test.go:	if gotR, wantR := got.Roots.Subjects(), want.Roots.Subjects(); !cmp.Equal(gotR, wantR, cmpopts.EquateEmpty()) {

And corresponding ignores of those usages in vet.sh pending PR; should hopefully be submitted relatively soon.

@milencium
Copy link

Heey there, I would love to help on this, can I maybe be assigned ? Thanks in advance

@dfawley
Copy link
Member Author

dfawley commented Dec 4, 2023

Sounds great, please send a PR; thanks!

@milencium
Copy link

@dfawley , thanks for this amazing opportunity, will do !

@miledxz
Copy link
Contributor

miledxz commented Dec 20, 2023

Heey @dfawley , could you assign me on this acc ? Im just using other acc, thank you

@dfawley dfawley assigned miledxz and unassigned milencium Dec 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants