removing deprecated http closenotifier function

[miledxz]

Regarding this little issue with deprecated function http.CloseNotify,
#6782

I have decided to add just small pr for http.CloseNotify deprecated

In this pull request, I have just removed the implementation, tests are going well,

my other approach was this:

to add and update onlyCloseNotifier interface, by doing this:

type onlyContext {
  http.ResponseWriter
  context.Context
}

then to update whole testHandlerResponseWriter with corresponding context.Context methods, like these:

type testHandlerResponseWriter struct {
    *httptest.ResponseRecorder
    done chan struct{}
    err error
    value any
    deadline time.Time
    ok bool
}

func (w testHandlerResponseWriter) Deadline() (deadline time.Time, ok bool) {return time.Time{}, false}
func (w testHandlerResponseWriter) Done() <-chan struct{}                              { return w.Result().Request.Context().Done() }
func (w testHandlerResponseWriter) Err() error                                                    {return nil}
func (w testHandlerResponseWriter) Value(key any) any                                     { return nil}

testHandlerResponseWriter{
        ResponseRecorder: httptest.NewRecorder(),
        done: make(chan struct{}, 1),
        err: nil,
        value: nil,
        deadline: time.Time{},
        ok: true,
}

But I suppose non of this is required ?

RELEASE NOTES: none

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: zedGGs / name: Mile Druzijanic (65f2d4a, b31db19)

[zasweq]

Hello, as I mentioned in the issue, we currently cannot take this change. If this change was taken, we would need to do it cross language. Hence, can you please file an issue at the link I listed in the issue you brought up. Thank you!

[dfawley]

I think this was the wrong PR? @zasweq ?

[codecov]

Codecov Report

Merging #6886 (b31db19) into master (bb0d32f) will increase coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6886      +/-   ##
==========================================
+ Coverage   83.65%   83.78%   +0.13%     
==========================================
  Files         286      286              
  Lines       30756    30756              
==========================================
+ Hits        25730    25770      +40     
+ Misses       3963     3936      -27     
+ Partials     1063     1050      -13     

see 19 files with indirect coverage changes

[dfawley]

But I suppose non of this is required ?

Yeah...it looks like nothing ever read from the notifier channel? SGTM as long as all the tests pass!

In the meantime, there is a lint error (just need to run gofmt):

https://github.com/grpc/grpc-go/actions/runs/7282068214/job/19843764206?pr=6886#step:7:259

[miledxz]

@dfawley , yes, thats exactly what I meant, notifier channel seems not to be required,
I have added update,

thank you for time and understanding with opening issue so we can proceed

[zasweq]

Oh whoops sorry wrong PR

[dfawley]

+@easwars for a second pass