Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exported function NewHandshakeInfo should have comment or be unexported #6806

Closed
arvindbr8 opened this issue Nov 16, 2023 · 0 comments · Fixed by #6823
Closed

exported function NewHandshakeInfo should have comment or be unexported #6806

arvindbr8 opened this issue Nov 16, 2023 · 0 comments · Fixed by #6823
Assignees
@zasweq
Labels
Type: Internal Cleanup Refactors, etc

Comments

@arvindbr8
Copy link
Member

Hola Zach Reyes,

Do you mind adding a doc comment to the exported constructor NewHandshakeInfo in https://github.com/grpc/grpc-go/blob/master/internal/credentials/xds/handshake_info.go#L94

Thanks!
@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label Nov 16, 2023
@zasweq zasweq mentioned this issue Nov 29, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zasweq zasweq

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal/credentials/xds: Add exported comment for HandshakeInfo zasweq/grpc-go
2 participants
@arvindbr8 @zasweq