Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/credentials/xds: Add exported comment for HandshakeInfo #6823

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Nov 29, 2023

Fixes #6806. This PR adds an exported comment for handshake info.

RELEASE NOTES: N/A

@zasweq zasweq added the Type: Documentation Documentation or examples label Nov 29, 2023
@zasweq zasweq added this to the 1.61 Release milestone Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #6823 (6d8482c) into master (bc16b5f) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6823   +/-   ##
=======================================
  Coverage   83.45%   83.45%           
=======================================
  Files         285      285           
  Lines       30879    30879           
=======================================
+ Hits        25769    25770    +1     
+ Misses       4042     4039    -3     
- Partials     1068     1070    +2     
Files Coverage Δ
internal/credentials/xds/handshake_info.go 88.81% <ø> (ø)

... and 22 files with indirect coverage changes

@arvindbr8 arvindbr8 assigned zasweq and unassigned arvindbr8 Nov 30, 2023
@zasweq zasweq merged commit 1b05500 into grpc:master Nov 30, 2023
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exported function NewHandshakeInfo should have comment or be unexported
2 participants