Get method string from stream #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
I signed it. |
menghanl
reviewed
Oct 18, 2017
stream.go
Outdated
| @@ -655,3 +655,12 @@ func (ss *serverStream) RecvMsg(m interface{}) (err error) { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // GetMethodFromStream returns the method string that the input stream is used for. | |||
There was a problem hiding this comment.
The returned string is in the format of "/service/method".
|
fix #1549 |
menghanl
reviewed
Oct 25, 2017
test/end2end_test.go
Outdated
| defer te.tearDown() | ||
| _ = te.clientConn().Invoke(context.Background(), "foo/bar", nil, nil) | ||
| if !ok || method != "foo/bar" { | ||
| t.Fatalf("Invoke with method \"foo/bar\", got %s, %v, want \"foo/bar\", true", method, ok) |
There was a problem hiding this comment.
Nit: define a testing const, and print %q to avoid escaping "s.
const testMethod = "/package.service/method"
if !ok || method != testMethod {
 t.Fatalf("Invoke with method %q, got %q, %v, want %q, true", testMethod, method, ok, testMethod)
}
menghanl
approved these changes
Oct 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1549