-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add support for Go1.6 #1603
Re-add support for Go1.6 #1603
Conversation
dfawley
commented
Oct 20, 2017
- Reverts Remove Go1.6 support #1492
- Fixes Add back support for Go 1.6 #1575
- Potentially impacts Import context from the standard library where possible census-instrumentation/opencensus-go#44 (cc @rakyll)
- Should probably be cherry-picked into 1.7.1
OpenCensus require 1.8 right now. We can relax this requirement if it is necessary to support OpenCensus gRPC integrations for 1.6. |
Happy to spend time to support 1.6 at OpenCensus if gRPC 1.6 support will not be discontinued in the near future. |
No comment on open census support. Official GCP libraries don't use it (yet), so there's not a large impact to customers using Go 1.6 on GAE. Or, does gRPC depend on opencensus? |
gRPC doesn't depend on OpenCensus directly. You can plug it in optionally. I am not going to execute on census-instrumentation/opencensus-go#61 for now given that OpenCensus Go libraries are still at the bootstrapping stage and gRPC may discontinue 1.6 support until we achieve maturity. /cc @bogdandrutu |
Sounds like a reasonable tradeoff to me! |