Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add support for Go1.6 #1603

Merged
merged 3 commits into from
Oct 20, 2017
Merged

Re-add support for Go1.6 #1603

merged 3 commits into from
Oct 20, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Oct 20, 2017

@dfawley dfawley added the Type: Dependencies Updating/adding/removing dependencies label Oct 20, 2017
@dfawley dfawley requested a review from menghanl October 20, 2017 16:07
@rakyll
Copy link

rakyll commented Oct 20, 2017

OpenCensus require 1.8 right now. We can relax this requirement if it is necessary to support OpenCensus gRPC integrations for 1.6.

@dfawley
Copy link
Member Author

dfawley commented Oct 20, 2017

Sounds good, thanks @rakyll. @broady, any input on OpenCensus's Go1.6 support?

@dfawley dfawley merged commit 5c3d956 into grpc:master Oct 20, 2017
@rakyll
Copy link

rakyll commented Oct 20, 2017

Happy to spend time to support 1.6 at OpenCensus if gRPC 1.6 support will not be discontinued in the near future.

@rakyll rakyll mentioned this pull request Oct 20, 2017
Closed
@broady
Copy link
Contributor

broady commented Oct 20, 2017 •
edited
Loading

No comment on open census support.

Official GCP libraries don't use it (yet), so there's not a large impact to customers using Go 1.6 on GAE.

Or, does gRPC depend on opencensus?

@rakyll
Copy link

rakyll commented Oct 23, 2017

gRPC doesn't depend on OpenCensus directly. You can plug it in optionally. I am not going to execute on census-instrumentation/opencensus-go#61 for now given that OpenCensus Go libraries are still at the bootstrapping stage and gRPC may discontinue 1.6 support until we achieve maturity.

/cc @bogdandrutu

@broady
Copy link
Contributor

broady commented Oct 23, 2017

Sounds like a reasonable tradeoff to me!

@dfawley dfawley deleted the readd16 branch November 3, 2017 15:51
@menghanl menghanl added this to the 1.8 Release milestone Nov 7, 2017
@jhump jhump mentioned this pull request Dec 14, 2017
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Milestone
1.8 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@dfawley @rakyll @broady @menghanl