fix max msg size type issues on different arch #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need this pull request so much! |
dfawley
approved these changes
Oct 26, 2017
rpc_util.go
Outdated
| @@ -274,7 +274,10 @@ func (p *parser) recvMsg(maxReceiveMessageSize int) (pf payloadFormat, msg []byt | |||
| if length == 0 { | |||
| return pf, nil, nil | |||
| } | |||
| if length > uint32(maxReceiveMessageSize) { | |||
| if int64(length) > int64(maxInt) { | |||
| return 0, nil, Errorf(codes.ResourceExhausted, "grpc: received message larger than max length allowed on current machine(%d vs. %d)", length, maxInt) | |||
There was a problem hiding this comment.
Nit: missing space before open paren in string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value range:
32-bit system: User API: int32, Service Config: int32, Max allowed slice length: int32, Max by spec: uint32
64-bit system: User API: int64, Service Config: int64, Max allowed slice length: int64, Max by spec: uint32