Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading default resolver scheme comments #1703

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Fix misleading default resolver scheme comments #1703

merged 1 commit into from
Nov 30, 2017

Conversation

therc
Copy link
Contributor

@therc therc commented Nov 30, 2017

Since a recent change, the default is passthrough, not dns.

@therc
Fix misleading default resolver scheme comments
db7e6ae 
Since a recent change, the default is `passthrough`, not `dns`.
menghanl
menghanl approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
LGTM.

@menghanl menghanl merged commit 00383af into grpc:master Nov 30, 2017
@dfawley dfawley added the Type: Documentation Documentation or examples label Jan 2, 2018
@dfawley dfawley added this to the 1.9 Release milestone Jan 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.9 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@therc @menghanl @dfawley