Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug preventing stream.Send() from receiving io.EOF after end of stream #1792

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Fix bug preventing stream.Send() from receiving io.EOF after end of stream #1792

merged 1 commit into from
Jan 18, 2018

Conversation

MakMukhi
Copy link
Contributor

@MakMukhi MakMukhi commented Jan 10, 2018 •
edited by dfawley
Loading

fixes #1755

@MakMukhi MakMukhi requested a review from dfawley January 10, 2018 20:05
@dfawley dfawley changed the title Write should fail when the stream was done but context wasn't cancelled. Fix bug preventing stream.Send() from receiving io.EOF after end of stream Jan 10, 2018
This was referenced Jan 10, 2018
Closed
Closed
@MakMukhi MakMukhi merged commit 46bef23 into grpc:master Jan 18, 2018
dfawley pushed a commit that referenced this pull request Jan 19, 2018
@MakMukhi @dfawley
Write should fail when the stream was done but context wasn't cancell…
6d5224a 
…ed. (#1792)
@menghanl menghanl added this to the 1.10 Release milestone Feb 14, 2018
@MakMukhi MakMukhi deleted the fix_write branch May 4, 2018 02:04
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
1.10 Release
Development

Successfully merging this pull request may close these issues.

ServerStream SendAndClose Does Not Close Stream
3 participants
@MakMukhi @dfawley @menghanl