-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transport: fix bug leading to hang when invalid headers are received #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to fix #2796 |
menghanl
reviewed
May 16, 2019
menghanl
approved these changes
May 22, 2019
canguler
changed the title
transport: Fix the inconsistency between headerChan and headerDone
[DO NOT MERGE] transport: Fix the inconsistency between headerChan and headerDone
May 22, 2019
canguler
changed the title
[DO NOT MERGE] transport: Fix the inconsistency between headerChan and headerDone
transport: Fix the inconsistency between headerChan and headerDone
May 22, 2019
menghanl
pushed a commit
that referenced
this pull request
Jun 4, 2019
…2818) transport: Fix the inconsistency between headerChan and headerDone
menghanl
changed the title
transport: Fix the inconsistency between headerChan and headerDone
transport: fix bug leading to hang when invalid headers are received
Jun 4, 2019
ncabatoff
added a commit
to hashicorp/vault
that referenced
this pull request
Jul 24, 2019
…nt ent test failures.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the inconsistency between headerChan and headerDone
fixes #2796