Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: fix bug leading to hang when invalid headers are received #2818

Merged
merged 5 commits into from
May 22, 2019
Merged

transport: fix bug leading to hang when invalid headers are received #2818

merged 5 commits into from
May 22, 2019

Conversation

canguler
Copy link

@canguler canguler commented May 16, 2019

Fix the inconsistency between headerChan and headerDone

fixes #2796

@canguler canguler requested a review from menghanl May 16, 2019 17:12
@canguler
Copy link
Author

Attempts to fix #2796

internal/transport/transport_test.go Outdated Show resolved Hide resolved
internal/transport/transport_test.go Outdated Show resolved Hide resolved
@canguler canguler requested a review from dfawley May 17, 2019 21:16
@canguler canguler changed the title transport: Fix the inconsistency between headerChan and headerDone [DO NOT MERGE] transport: Fix the inconsistency between headerChan and headerDone May 22, 2019
@canguler canguler changed the title [DO NOT MERGE] transport: Fix the inconsistency between headerChan and headerDone transport: Fix the inconsistency between headerChan and headerDone May 22, 2019
@canguler canguler merged commit 25ad15b into grpc:master May 22, 2019
@dfawley dfawley added this to the 1.22 Release milestone May 23, 2019
menghanl pushed a commit that referenced this pull request Jun 4, 2019
…2818)

transport: Fix the inconsistency between headerChan and headerDone
@menghanl menghanl changed the title transport: Fix the inconsistency between headerChan and headerDone transport: fix bug leading to hang when invalid headers are received Jun 4, 2019
ncabatoff added a commit to hashicorp/vault that referenced this pull request Jul 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream got stuck in waitOnHeader even after the underlying transport has gone away
3 participants