Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test coverage #363

Merged
merged 9 commits into from
Oct 2, 2015
Merged

Enable test coverage #363

merged 9 commits into from
Oct 2, 2015

Conversation

iamqizhao
Copy link
Contributor

No description provided.

@mattn
Copy link
Contributor

mattn commented Sep 26, 2015

goveralls run go test. is this same on grpc-go?

@iamqizhao
Copy link
Contributor Author

Yes, please take a look at
https://github.com/grpc/grpc-go/blob/master/Makefile.

On Sat, Sep 26, 2015 at 8:30 AM, mattn notifications@github.com wrote:

goveralls run go test. is this same on grpc-go?


Reply to this email directly or view it on GitHub
#363 (comment).

@mattn
Copy link
Contributor

mattn commented Sep 27, 2015

then do goveralls google.golang.org/grpc/...

@iamqizhao
Copy link
Contributor Author

I still got this:

0.05s$ goveralls google.golang.org/grpc/...
can't load package: package github.com/grpc/grpc-go: code in directory /home/travis/gopath/src/github.com/grpc/grpc-go expects import "google.golang.org/grpc"
error: exit status 1
17:23:15 gocov.go:134: Error loading gocov results: exit status 1
The command "goveralls google.golang.org/grpc/..." exited with 1.
Done. Your build exited with 1.

@mattn
Copy link
Contributor

mattn commented Sep 29, 2015

go get before execute goveralls.

like Makefile is doing as testdep https://github.com/grpc/grpc-go/blob/master/Makefile#L40-L41

@iamqizhao
Copy link
Contributor Author

Updated the PR. Still got that error:

0.28s$ make coverage
go get -d -v -t google.golang.org/grpc/...
goveralls google.golang.org/grpc/...
can't load package: package github.com/grpc/grpc-go: code in directory /home/travis/gopath/src/github.com/grpc/grpc-go expects import "google.golang.org/grpc"
error: exit status 1
00:47:43 gocov.go:134: Error loading gocov results: exit status 1
make: *** [coverage] Error 1
The command "make coverage" exited with 2.

@mattn
Copy link
Contributor

mattn commented Sep 29, 2015

could you please try with -v?

@iamqizhao
Copy link
Contributor Author

It does not add any useful info.

The command "make test testrace" exited with 0.
0.15s$ make coverage
go get -d -v -t google.golang.org/grpc/...
goveralls -v google.golang.org/grpc/...
can't load package: package github.com/grpc/grpc-go: code in directory /home/travis/gopath/src/github.com/grpc/grpc-go expects import "google.golang.org/grpc"
error: exit status 1
01:58:00 gocov.go:134: Error loading gocov results: exit status 1
make: *** [coverage] Error 1
The command "make coverage" exited with 2.

Let me know if you are interested in taking this over. :)

iamqizhao added a commit that referenced this pull request Oct 2, 2015
@iamqizhao iamqizhao merged commit 5ed03f2 into grpc:master Oct 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants