Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Exit from run() goroutine when resolver is closed. #3882

Merged
merged 1 commit into from
Sep 16, 2020
Merged

xds: Exit from run() goroutine when resolver is closed. #3882

merged 1 commit into from
Sep 16, 2020

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Sep 16, 2020

Also switch the resolver tests to use the leakchecker.
Fixes #3873.

@easwars easwars added this to the 1.33 Release milestone Sep 16, 2020
@easwars easwars merged commit 9ec6f11 into grpc:master Sep 16, 2020
@easwars easwars deleted the xds_resolver_run branch September 16, 2020 21:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@menghanl menghanl Awaiting requested review from menghanl

Assignees

@menghanl menghanl

Labels
Type: Bug
Projects
None yet
Milestone
1.33 Release
Development

Successfully merging this pull request may close these issues.

xdsResolver run() in a loop, consume a lot of CPU
3 participants
@easwars @dfawley @menghanl