xds: Ignore application_protocols field for now #4115
Conversation
|
There seems to be ongoing discussions about what exactly would be sent down in this field by the control plane. So, all three languages have decided to not check this field for now, and once the discussions yield some decisions we will go ahead and implement required checks. |
| fcs := lis.GetFilterChains() | ||
| if n := len(fcs); n != 1 { | ||
| return nil, fmt.Errorf("xds: filter chains count in LDS response does not match expected. Got %d, want 1", n) | ||
| } | ||
| fc := fcs[0] | ||
| aps := fc.GetFilterChainMatch().GetApplicationProtocols() |
There was a problem hiding this comment.
Just a thought: would it make sense to leave a comment here?
Thinking probably no? Since there are plenty fields that we don't check. And when a decision is made, we will come back and add the required check anyway.
There was a problem hiding this comment.
A bug is open where the discussion is happening. So, once the decision is made, I think all three languages will come back and implement the decision. So, I'm ok not adding a comment here. Thanks.
No description provided.